andybalholm / redwood

Web content filter that runs as an HTTP proxy
BSD 2-Clause "Simplified" License
225 stars 37 forks source link

Error in the README example of blockpage value #50

Closed elico closed 4 years ago

elico commented 4 years ago

For quite a while I didn't found what is causing my setup to generate bad block page. ie empty pages.. In the README the example is: blockpage "/etc/redwood/block.html"

but it only works like this: blockpage /etc/redwood/block.html

Without the double quotes.

andybalholm commented 4 years ago

After 8 years, somebody noticed the bug! It’s fixed on the master branch now.

Andy

On Mar 26, 2020, at 6:57 AM, Eliezer Croitoru notifications@github.com wrote:

For quite a while I didn't found what is causing my setup to generate bad block page. ie empty pages.. In the README the example is: blockpage "/etc/redwood/block.html"

but it only works like this: blockpage /etc/redwood/block.html

Without the double quotes.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/andybalholm/redwood/issues/50, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGUELB5KDXCDYQT4YOSOD3RJNNM7ANCNFSM4LUH6KPQ.

elico commented 4 years ago

Actually I noticed since day 0 but.. only now back to testing.

After 8 years, somebody noticed the bug! It’s fixed on the master branch now. Andy