search

andybalholm / spamass-milter

A Sendmail milter to run SpamAssassin
7 stars 9 forks source link

Allow tempfails (in a more digestible way) #5

Closed LarsKollstedt closed 4 years ago

LarsKollstedt commented 4 years ago

Hi,

this is thought to replace pull request #4 since I can't switch it to another branch.

I've split up the changes into the three features. They are in the order I added them since each of them is adding an element to args and from the first to the last it changes from const char args = "afd:mMp:P:r:u:D:i:b:B:e:xS:R:C:g:T:"; to const char args = "aAfd:mMp:P:r:l:u:D:i:b:B:e:xS:R:c:C:g:T:"; .

Otherwise the -A would option would be independent of that. The -c and the -l strongly interacct.

Putting this in this form together would make the changes better readable. The result is the same as requested in #4. During preparing this I found the misstake corrected in 9f779d31f1ff494a88039968d1f81c7f7038976.

Oops, I've just seen you've just pulled this. Choose which would be the better one. ;-)

Kind regards, Lars

andybalholm commented 4 years ago

That was a real test of my git skills, but I think I've successfully replaced the old version with the new one.

LarsKollstedt commented 4 years ago

Hi Andy,

looks fine. :-) :+1

Sorry for this challenge. But I didn't think of this automatically generated message from github would make you pull this. ;-)

Many thanks.

Kind regards Lars