andyblac / UI-Minimalist-Custom-Cards

A modified version of Minimalist Room Card.
58 stars 3 forks source link

Update Room Card to add Custom icon #11

Closed mon3y78 closed 9 months ago

andyblac commented 10 months ago

don't forget to merge latest changes from dev into your branch. and update

andyblac commented 10 months ago

thanks, can you bump the version 2.0.6, and update the docs for room card.

mon3y78 commented 10 months ago

bump to 2.0.6? where is?

andyblac commented 10 months ago

here https://github.com/mon3y78/UI-Minimalist-Custom-Cards/blob/dev/custom_cards/custom_card_andyblac_room/custom_card_andyblac_room.yaml#L3

and add to docs in room card, the version section.

Changelog

2.0
2.0.1
2.0.2
2.0.3
2.0.4
2.0.5
andyblac commented 10 months ago

maybe rename to custom1 and custom2 , what you think ?, and add the BREAKING CHANGE message in docs

ie above Changes add something like, plus theres no need to bump to 2.0.7, as 2.0.6 has not been released yet. so just leave as 2.0.6

## Breaking Changes

<details>
<summary>2.0.6</summary>
rename `climate` object to `custom1`
</details>

or custom2 if you prefer.

mon3y78 commented 10 months ago

ok. this is the first time I've used github at this level. thanks for all the advice.

andyblac commented 10 months ago

no problem, glad for your contribution :)

mon3y78 commented 10 months ago

up and down easily characterizes their position custom_up costom_down ?

andyblac commented 10 months ago

up and down easily characterizes their position

yes but lets try to keep inline with the others, sensor_1 sensor_2, so let use custom_1 and custom_2.

andyblac commented 9 months ago

can you update the changes requested ?

andyblac commented 9 months ago

no, there still loads of issues, leave it with me i'll added.

andyblac commented 9 months ago

ok, done it should be in Dev branch, thanks.