andybrewer / mvp

MVP.css — Minimalist classless CSS stylesheet for HTML elements
https://andybrewer.github.io/mvp/
MIT License
4.98k stars 192 forks source link

feat: :sparkles: add `styles` for `dialog` element & its `backdrop` #122

Closed krypton225 closed 1 week ago

krypton225 commented 1 week ago

Description

This PR implements new styles to address an issue with heading elements inside the dialog HTML element.

The goal is to:

Changes Made

Screenshot

image

Additional Notes

ChristopherBilg commented 1 week ago

Hey Krypton! I'm more than happy to review this and potentially add some of it; however, MVP.css is designed and intended to be an Out of the box CSS styling for HTML elements. No class names, no framework to learn. I see the majority of your proposed changes are in class names. If you'd like to refactor those into CSS combinators (and the like), then I would be happy to include these changes.

krypton225 commented 1 week ago

@ChristopherBilg

Thank you very much! I'm happy to read your awesome comment.

OK. As you said: MVP.css is designed and intended to be an Out-of-the-box CSS styling for HTML elements. No class names, no framework to learn..

Do you need to remove the classes only, with the example of course, and push a new commit?