andycasey / smhr

Spectroscopy Made Hard(er)
14 stars 7 forks source link

Py38 mpl313 [WIP do not merge yet] #334

Closed alexji closed 2 years ago

alexji commented 3 years ago

It's taken a few years, but I've now successfully ported SMHR to python 3. It uses pyside2/Qt5 and updated matplotlib libraries. This means it is now installable using conda libraries. It also appears to work with Big Sur/M1 macs. Since the Python 2 version of SMHR is now actually impossible to install, I suggest having this as the master branch.

I've been using this version exclusively for a month or two now, and it seems to be working fine; maybe it's a bit slower than the original, and with a few GUI glitches, but nothing preventing functionality. It has been installed on a few students' computers (Linux and M1) and they use it successfully.

It also includes my latest and greatest keyboard shortcuts for the Line Measurements tab that greatly speed up the process (using j/k to scroll between lines, space to check/uncheck, F to flag/unflag while you are clicked into the spectrum plot). Possible concerns:

Important to dos still that shouldn't prevent the PR:

alexji commented 3 years ago

OOPS the big problem right now is I accidentally merged the RPA version into the main SMHR branch on github (instead of vice-versa). This needs to be undone since I like the version we had previously.

alexji commented 2 years ago

After a few months of continuing to work with this, it seems like it is stable (or at least much more so than the python 2 version). So we are biting the bullet and merging this into master.