Support mobile - Githubissues

andychase / gbajs2

gbajs2 is a Game Boy Advance emulator written in Javascript from scratch using HTML5 technologies like Canvas and Web Audio. It is freely licensed and works in any modern browser without plugins.

https://andychase.me/gbajs2

BSD 2-Clause "Simplified" License

212 stars 76 forks source link

Support mobile #21

Open keicoon opened 3 years ago

keicoon commented 3 years ago

Add Some feature for mobile

Add mobile.index, npm server.js , mobile-css file
Virtual Pad ( TODO: use canvas, not button dom )
Fix bug in util Serializer
Using https ( for Accessing save and load file )

Thanks :)

keicoon commented 3 years ago

Test is success in safari for ios , chrome for ios :)

andychase commented 3 years ago

Sorry for the delay in reviewing this.

First of all huge thanks in doing this work, I'm extremely grateful for the time spent here.

I'm going to merge this to a new branch called "mobile"

Some feedback:

What do you think about trying to reconcile the desktop and mobile versions of the application? I personally believe in progressive enhancement so having one page that supports both mobile and desktop.
What's the advantage of adding an express server? Trying to keep things simple but if there's a good reason to include it then I understand

andychase commented 3 years ago

I merged your PR into the mobile branch

chunibyo-wly commented 3 years ago

Hello, thanks for your work. if have I want to play this version, should I deploy by myself?

andychase commented 3 years ago

@chunibyo-wly yes right now I haven’t merged this onto the website, mostly because I would have to the express dependency for it to work with GitHub pages