andycmaj / react-chat-renderer

React JSX factory implementation for Slack

15 stars 0 forks source link

Typescript #16

Closed andycmaj closed 4 years ago

andycmaj commented 4 years ago

this is kinda still a work in progress in that i'd like feedback and to fix things that are confusing that might have better ways of representing

summary

add typescript types for all components and their props/slack api return types.
should be compatible with react jsx in same project (using some combination of typescript jsxFactory config and /** @jsx */ pragma)

todo

better validation for children

davemeyer commented 4 years ago

just the questions above about the usefulness of some of the interfaces. but overall it seems pretty clear and easy to work with. way nicer than it was before for sure. oh and there were several other instances of unused imports. didn't mark/find them all, but you might want to double check that before merging

andycmaj commented 4 years ago

@davemeyer i can wait till #15 is merged then update this one last time to grab the MessageText component before merging

davemeyer commented 4 years ago

if this is ready you can go for it now. i'm still dabbling with the component prop. but if you want to wait, dats coo

andycmaj commented 4 years ago

ok i'll shap it