search

andydandy74 / ClockworkForDynamo

A collection of 450+ custom nodes for the Dynamo visual programming environment
MIT License
221 stars 96 forks source link

ParameterFilterElement.FilterRuleString returns null with OR Rules #402

Closed l-schmidt closed 7 months ago

l-schmidt commented 8 months ago

Describe the bug I am using the node ParameterFilterElement.FilterRuleString to extract filters and their rules from a Project File. I extracted 113 Filters using this node, and most rules come out fine. A handful return null, which I realized they are all OR Rules.

Steps to Reproduce Used node, and works as expected, except for OR Rules. Some screenshots below, for reference:

Item 3 is an OR Rule. Here it is in Dynamo: image

And here it is in the Filter Dialog in Revit: image

Expected behavior I expect the rule to output the same as the others in this node.

My setup

andydandy74 commented 8 months ago

@l-schmidt I can't reproduce this based on your screenshot. Could you transfer the problematic filters to an empty model and post that here? Looking at your Dynamo screenshot I see at least one OR rule that had no issue so I'm thinking this is caused by something else, most probably a combination of parameters and selected categories.

andydandy74 commented 7 months ago

@l-schmidt I am going to close this for now. Feel free to re-open with a sample model of your issue.

l-schmidt commented 7 months ago

gah, I missed your comments. this is from a client's project file, so I can't share directly, but I will try to reproduce in another file that I can send you. I do see that there is another OR that is working. very strange... I will do more investigating and get back to you

l-schmidt commented 7 months ago

Okay, I ripped the Filters into an empty file and was able to reproduce. Here is a link to download the .rvt and .dyn file: https://parallaxteam.sharefile.com/public/share/web-sc73a8a32025349079eeddc8aa6f16391

I don't think I can re-open this issue...

andydandy74 commented 7 months ago

Thanks, I'll have a look.

andydandy74 commented 7 months ago

@l-schmidt - This looks good on my end:

grafik

Are you sure you're using the latest Clockwork release? I did some work on this node for the last release (2.6.0) and it shouldn't produce a null result for this type of filter.

https://github.com/andydandy74/ClockworkForDynamo/wiki/Version-History#bug-fixes-1

l-schmidt commented 7 months ago

Took me a little while to figure out how to check my version... and you're right. It is 2.4.0. 🤦