andydandy74 / ClockworkForDynamo

A collection of 450+ custom nodes for the Dynamo visual programming environment
MIT License
221 stars 96 forks source link

Rooms.Finishes node doesn't work with room using a room separator #433

Closed auredor closed 4 weeks ago

auredor commented 1 month ago

Describe the bug (Please fill in. A clear and concise description of what the bug is. In most cases, it will be helpful if you include screenshots and/or journal files.)

in Revit 2025.2, Rooms.Finishes Node from clockwork package 2.12.0 doesn't work for room partially delimited with a room separator line. The node returns "Empty List" for those particular rooms but it works well for the other ones. Using node code from clockwork package 2.6.0 in a custom python node returns the expected results.

Steps to Reproduce (Please fill in. What did you do, step by step?)

Draw a floor plan in Revit but use a room separator line to split one of the room. In Dynamo, connect rooms collector node to rooms.Finishes node et run it

Expected behavior (Please fill in. A clear and concise description of what you expected to happen.)

Get the room finishes of room using a room separator lines

My setup

Housekeeping Please make sure these boxes are checked before submitting your issue:

andydandy74 commented 1 month ago

I could reproduce this in Revit 2024 as well. You can download the fixed node here: https://github.com/andydandy74/ClockworkForDynamo/blob/master/nodes/2.x/Room.Finishes.dyf

andydandy74 commented 4 weeks ago

Now available on the package manager in new package version 2.12.1