search

andydelso / aperture

An app to track Oscar nominees you have watched using KMP
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Allow users to check off nominees with db persistance #2

Closed andydelso closed 6 months ago

andydelso commented 6 months ago

closes #1

This will need updating to the shared VM in the future but I was studying this today pre interview to remember how to hoist the state and click actions into the VM. Please take a look at that @CodyEngel if you have a few as I feel like it might somehow be backwards with the lambdas?

I want to get tests in soon for the shared code. So I will be adding that to the board soon.

Per the video below, checking the box is held when put into the background and when closed. Not shown, Android Studio has a db inspector that showed the column value being toggled to 1 or 0 depending on if checked or not.

https://github.com/ddaypunk/aperture/assets/2991755/8cf8e2eb-25e4-4666-8105-173aea1bd855

gionoa commented 6 months ago

I think for the UI to just have the list expanded to start with (and not need the dropdown)

andydelso commented 6 months ago

I think for the UI to just have the list expanded to start with (and not need the dropdown)

@gionoa I was thinking the same thing and might have a comment locally for that. I don't have the state for that hoisted into the view model really. Once we do that, we can just say have the most recent one be expanded. That would be only in the uistate though and have no bearing on the db data.

andydelso commented 6 months ago

@gionoa I abstracted those mapping methods (auto-generated by IDE for now) as you mentioned. Manually tested and it works as expected. Lemme know if that is good enough and then I will merge.

Also created #8 to track the similar feedback you had about the collapsed card. It'll take hoisting the card state into the viewmodel and going from there. I may just take care of that when I attempt the shared viewmodel.