andydoroga1989 / gwt-google-apis

Automatically exported from code.google.com/p/gwt-google-apis
0 stars 0 forks source link

Add missing implementation in Response class in createResponse method in com.google.gwt.gadgets.client.gwtrpc.GadgetsRequest class. #391

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Detailed description:
The class Reponse created in the method `createResponse` in 
`com.google.gwt.gadgets.client.gwtrpc.GadgetsRequest` should add an 
implementation for the methods `getHeader`, `getHeaders` and 
`getHeadersAsString`. Currently these methods return null.

Related to this is the class `com.google.gwt.gadgets.client.io.Response` from 
which that information is obtained. It needs at minimal the method 
`getHeaders() to be added and preferable the method `getHeadersAsString`.

Links to the relevant GWT Developer Forum posts:
http://groups.google.com/group/gwt-google-apis/browse_thread/thread/e9413ba31020
1042

Original issue reported on code.google.com by hs@h72.nl on 25 Jun 2010 at 1:25

GoogleCodeExporter commented 9 years ago
Our intention is to make this class invisible for the end user (it's not 
public), and therefore it doesn't need any operations on headers, as they're 
not used in the RPC itself. Other problem is that it's actually not that easy 
to create a reasonable integration between gadgets.io.GadgetsIo and 
com.google.gwt.http.client.Response interface.

To summarize: We're not going to implement missing methods, as existing 
implementation works well with the task it was created for. On the other hand, 
if someone would like to create a fully functional GWT RPC wrapper around 
GadgetsIo, patches welcome.

Original comment by piotr.sw...@gmail.com on 25 Jun 2010 at 4:05