Re-ordering of header processing to prevent gmail headers being lost

andyedinborough / aenetmail

C# POP/IMAP Mail Client

370 stars 153 forks source link

Re-ordering of header processing to prevent gmail headers being lost #118

Closed mungojam closed 11 years ago

mungojam commented 11 years ago

The gmail thread ID was being lost because the MailMessage.Headers were being set to null in the Load method after the custom headers had been added.

It looks like a more significant refactor would be good, perhaps making the MailMessage immutable.

But for now, this seems to work fine.

This is my first ever pull request. Any feedback welcome.

andyedinborough commented 11 years ago

Looks good (except for an incorrect tab size ;]). Thanks!

mungojam commented 11 years ago

Oops. Wouldn't normally miss something like that. Should have done a ctrl+k+d. Thanks for the library, helped me do a small project in 3 hours this afternoon.

andyedinborough commented 11 years ago

You are forgiven my son. ;] glad it was useful for you. I'll get an update on nuget soon.