search

andyedinborough / aenetmail

C# POP/IMAP Mail Client
370 stars 153 forks source link

Fixes for NewMessage and GetMessages #17

Closed petersondrew closed 12 years ago

petersondrew commented 12 years ago

https://github.com/andyedinborough/aenetmail/issues/1 Removing one extra call to GetResponse which I'm assuming is a typo.

https://github.com/andyedinborough/aenetmail/issues/16 Checking that message count > 0 before raising NewMessage. This seems like the correct thing to do, but I could be misreading the specs for IDLE.

andyedinborough commented 12 years ago

This is good stuff; good catches, but the IDLE command should never encounter results from other commands. I'll need to review the entire class. Anytime any other command is sent, IDLE should be canceled first. In my testing, IMAP servers didn't support asynchronous commands. So, if another result comes in, this is an error condition.

So I'm going to un-comment that section, and then review the rest of the class and see if I can figure out why other command responses are coming in.

petersondrew commented 12 years ago

Sounds good, thanks for looking into it. Let me know if you need any more information or if you need an example of code that causes this condition. I'm using Gmail, so it's also possible their implementation of IMAP is non-standard.