andyedinborough / aenetmail

C# POP/IMAP Mail Client
370 stars 153 forks source link

Revamped IMAP IDLE code and bugfixes #93

Closed smiley22 closed 11 years ago

smiley22 commented 12 years ago

Hello,

I downloaded AE.Net.Mail the other day in search of an IMAP lib that would allow my application to receive IMAP IDLE notifications. AE.Net.Mail is awesome but I think the code that deals with IMAP IDLE has some issues with thread synchronization and it will also not always cleanly shutdown.

I spent the last couple of days rewriting parts of it and after trying several different approaches, it is now working rather nicely. I also added a bit of documentation to a couple of methods as well. If anyone feels like reviewing my changes, please do and if you think they are alright, maybe we can get them into the repository.

I also re-worked the ParseMime method as it would get confused when parsing messages with empty content bodies.

Cheers, smiley22

ps. this also fixes a bug in GetMessages as described in #86

galringel commented 12 years ago

Hi, Did someone review your changes? What is your e-mail?

smiley22 commented 12 years ago

Hi, no not yet, andy's probably busy with other stuff right now. anyway i have since rewritten so much of the original code i decided it'd be better to spin this off into a new project.

galringel commented 12 years ago

Nice work! Can I please get your re-factored code? Where can i find it?

Thanks.

smiley22 commented 12 years ago

Hello, you can find it on my github page under S22.Imap

NadavK commented 11 years ago

smiley22 - thanks for your forked S22 project - it fixes the issue I had with Andy's project: 1) only fires events for the first few new emails 2) not able to reconnect after loosing internet connectivity.