search

andyferris / Dictionaries.jl

An alternative interface for dictionaries in Julia, for improved productivity and performance
Other
278 stars 28 forks source link

Enable set operations between `AbstractIndices` and abitrary itr #102

Closed BSnelling closed 2 years ago

BSnelling commented 2 years ago

Relaxes the types on the mutating methods of set operations so as to match the dispatch pattern in Base. This means that set operations where the first argument is <:AbstractIndices and the second is any valid itr will return an Indices with the result.

Fix for https://github.com/andyferris/Dictionaries.jl/issues/100

codecov[bot] commented 2 years ago

Codecov Report

Merging #102 (b96ad93) into master (1510dac) will increase coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
+ Coverage   77.08%   77.11%   +0.02%     
==========================================
  Files          18       18              
  Lines        1999     2001       +2     
==========================================
+ Hits         1541     1543       +2     
  Misses        458      458
Impacted Files Coverage Δ
src/insertion.jl 71.00% <100.00%> (ø)
src/AbstractDictionary.jl 85.81% <0.00%> (+0.10%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1510dac...b96ad93. Read the comment docs.