andyferris / Dictionaries.jl

An alternative interface for dictionaries in Julia, for improved productivity and performance
Other
278 stars 28 forks source link

add sortperm #105

Closed aplavin closed 1 year ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #105 (8564278) into master (024daeb) will increase coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
+ Coverage   77.11%   77.13%   +0.02%     
==========================================
  Files          18       18              
  Lines        2001     2003       +2     
==========================================
+ Hits         1543     1545       +2     
  Misses        458      458              
Impacted Files Coverage Δ
src/Dictionary.jl 80.00% <100.00%> (+0.10%) :arrow_up:
src/Indices.jl 88.28% <100.00%> (+0.03%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 024daeb...8564278. Read the comment docs.

andyferris commented 1 year ago

I got excited: https://github.com/JuliaRegistries/General/pull/65366

aplavin commented 1 year ago

Great! I think this is quite efficient for Indices, less so for Dictionaries: it sorts the whole dict and then only takes its indices. But sortperm is generally pretty slow in Julia, unfortunately, so it shouldn't make that much of a difference.

andyferris commented 1 year ago

Yeah, exactly