Closed theogf closed 1 year ago
Merging #107 (5157401) into master (34c17d0) will increase coverage by
0.03%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #107 +/- ##
==========================================
+ Coverage 78.75% 78.78% +0.03%
==========================================
Files 20 20
Lines 2320 2324 +4
==========================================
+ Hits 1827 1831 +4
Misses 493 493
Impacted Files | Coverage Δ | |
---|---|---|
src/Indices.jl | 88.13% <100.00%> (+0.07%) |
:arrow_up: |
src/UnorderedIndices.jl | 88.78% <100.00%> (+0.10%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Would you like me to tackle serialize
/deserialize
also in this PR or make a new one?
It's generally preferable to have smaller, orthogonal PRs. If this is ready to merge we can do that and create a new one?
But also happy if you continue to work on this branch if that is better for you.
It's generally preferable to have smaller, orthogonal PRs. If this is ready to merge we can do that and create a new one?
But also happy if you continue to work on this branch if that is better for you.
LGTM then :)
I wrapped the @testset
s in a global @testset
, otherwise the tests will just stop at the first failed @testset
. I can revert it if you don't like it.
Yeah that should be fine
Sweet, thanks @theogf :)
When using
deepcopy
onDictionary
with nonisbits
indices, there will be a mismatch between the hashes (unchanged) and the new objects (different hash). This PR should fix this by overloadingdeepcopy_internal
as suggested in theBase
docs.I will just add some docs with an MWE where
master
would fail.