search

andyferris / Dictionaries.jl

An alternative interface for dictionaries in Julia, for improved productivity and performance
Other
278 stars 28 forks source link

Add merge and friends with arbitrary number of args #130

Closed pablosanjose closed 5 months ago

pablosanjose commented 5 months ago

Closes #129

adds methods for merge, merge!, mergewith and mergewith! with arbitrary number of AbstractDictionary args.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7b5b7b3) 79.35% compared to head (81a3062) 80.10%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #130 +/- ## ========================================== + Coverage 79.35% 80.10% +0.74% ========================================== Files 21 20 -1 Lines 2349 2357 +8 ========================================== + Hits 1864 1888 +24 + Misses 485 469 -16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pablosanjose commented 5 months ago

Thanks for the quick reply and review! Regarding upping the compatibility requirement to 1.6, it's your call. I would personally do it, since 1.6 has been out very long now. Please let me know. EDIT: Thinking about that again, I believe it's better practice to do the compat change in a separate PR.

andyferris commented 5 months ago

Re Julia 1.6, the question I have is this a breaking change? Do we need a major version bump? I suppose the package manager will deal with it for us.

pablosanjose commented 5 months ago

Nope, it's not a breaking change (with the last commit). It can be argued that it is a bugfix (so bugfix release), since it just makes merge and co on AbstractDictionaries compliant with the API defined by Julia for AbstractDict.

andyferris commented 5 months ago

Sorry, my comment was about changing the minimum compatible Julia version to 1.6. In any case, such a decision can be dealt with seperately. (I agree this is more of a bugfix).

Thanks again!