search

andyferris / Dictionaries.jl

An alternative interface for dictionaries in Julia, for improved productivity and performance
Other
282 stars 28 forks source link

Fix `deepcopy` when used after `delete!` #134

Closed nhz2 closed 8 months ago

nhz2 commented 8 months ago

Fixes #133

The bug fixed in #112 was reintroduced in #131 when one of the deepcopy_internal methods was deleted.

I have added a basic test for this issue, but I think deepcopy needs more testing.

CC: @stev47 @andyferris @theogf

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (74e716c) 80.24% compared to head (5eec1d9) 80.23%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #134 +/- ## ========================================== - Coverage 80.24% 80.23% -0.01% ========================================== Files 21 21 Lines 2359 2363 +4 ========================================== + Hits 1893 1896 +3 - Misses 466 467 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nhz2 commented 8 months ago

Thank you for maintaining this package and quickly fixing this.