search

andyferris / Dictionaries.jl

An alternative interface for dictionaries in Julia, for improved productivity and performance
Other
282 stars 28 forks source link

make AbstractDictionary a subtype of AbstractDict #141

Closed Tortar closed 7 months ago

Tortar commented 7 months ago

Would this be a problem? This would make it easier to use Dictionary if an AbstractDict is already supported by a library

andyferris commented 7 months ago

The issue here is that we completely violate the AbstractDict interface, in lots of ways. Most code that works with one won’t work with the other, so this would quite likely result in bugs downstream.

Tortar commented 7 months ago

that's bad then, thank you for the clarification