search

andyferris / Dictionaries.jl

An alternative interface for dictionaries in Julia, for improved productivity and performance
Other
282 stars 28 forks source link

Rename HashIndices -> Indices, Indices -> ArrayIndices #23

Closed andyferris closed 4 years ago

andyferris commented 4 years ago

In #8 we saw confusion about the names. Personally I'm sick of type HashIndices and HashDictionary everywhere.

I've revamed the old Indices into an array-only ArrayIndices which should have tighter semantics (be more reliable and maintainable). Perhaps one day we can have a ZipDictionary or FromPairsDictionary that is purely iteration based? (Also TupleDictionary, StaticDictionary... hmm...)

Fixes #7. Resolves #8. Makes me happy.

codecov[bot] commented 4 years ago

Codecov Report

Merging #23 into master will decrease coverage by 0.20%. The diff coverage is 70.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #23      +/-   ##
==========================================
- Coverage   63.95%   63.74%   -0.21%     
==========================================
  Files          18       18              
  Lines        1326     1335       +9     
==========================================
+ Hits          848      851       +3     
- Misses        478      484       +6
Impacted Files Coverage Δ
src/AbstractDictionary.jl 82.77% <0.00%> (-0.48%) :arrow_down:
src/Dictionaries.jl 100.00% <ø> (ø)
src/PairDictionary.jl 53.33% <ø> (ø)
src/Dictionary.jl 61.61% <62.50%> (-10.89%) :arrow_down:
src/ArrayDictionary.jl 62.79% <62.79%> (ø)
src/Indices.jl 74.34% <74.23%> (+2.55%) :arrow_up:
src/ArrayIndices.jl 77.77% <77.77%> (ø)
src/AbstractIndices.jl 61.11% <100.00%> (ø)
src/insertion.jl 64.33% <100.00%> (-0.70%) :arrow_down:
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 05f59fb...293988d. Read the comment docs.