search

andyferris / Dictionaries.jl

An alternative interface for dictionaries in Julia, for improved productivity and performance
Other
278 stars 28 forks source link

Remove reference to unimplemented function #46

Closed nickrobinson251 closed 3 years ago

nickrobinson251 commented 3 years ago

Hello! I was just getting to grips with this very cool package, working through the docs, and i noticed that the mapview function mentioned in the README isn't actually (yet?) implemented. Should it just be removed from the README for now? Should there be an issue about introducing such a function?

codecov[bot] commented 3 years ago

Codecov Report

Merging #46 (67ae7a1) into master (e4d8e02) will increase coverage by 0.08%. The diff coverage is n/a.

:exclamation: Current head 67ae7a1 differs from pull request most recent head 2f2b509. Consider uploading reports for the commit 2f2b509 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
+ Coverage   70.31%   70.39%   +0.08%     
==========================================
  Files          19       19              
  Lines        1701     1699       -2     
==========================================
  Hits         1196     1196              
+ Misses        505      503       -2
Impacted Files Coverage Δ
src/tokens.jl 21.87% <0.00%> (-0.35%) :arrow_down:
src/map.jl 26.74% <0.00%> (+0.30%) :arrow_up:
src/broadcast.jl 50.79% <0.00%> (+0.79%) :arrow_up:
src/indexing.jl 58.62% <0.00%> (+0.99%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e4d8e02...2f2b509. Read the comment docs.