search

andyferris / Dictionaries.jl

An alternative interface for dictionaries in Julia, for improved productivity and performance
Other
278 stars 28 forks source link

Feature-request: Support Base.haskey #53

Closed schlichtanders closed 3 years ago

schlichtanders commented 3 years ago

Hi (sorry for the dense opening of issues, I hope you appreciate my attempt to just help)

Just stumbled upon Base.haskey, which is quite standard for Base.AbstractDict and makes especially sense for AbstractDictionary as well, because the iterator does not go over the keys, but the values, so plain in is still not working.

Would be great to have it for completenes

schlichtanders commented 3 years ago

Currently falling back to key in keys(d)

andyferris commented 3 years ago

Nice catch! It was intended to be implemented as key in keys(d), but clearly I forgot to add that. I'll fix that up :)

sorry for the dense opening of issues, I hope you appreciate my attempt to just help

Don't be sorry - I appreciate the help!

andyferris commented 3 years ago

Fixed in the 0.3.10 release.