search

andyferris / Dictionaries.jl

An alternative interface for dictionaries in Julia, for improved productivity and performance
Other
282 stars 28 forks source link

use `sizehint` for hash and value arrays as well #74

Closed simeonschaub closed 2 years ago

simeonschaub commented 2 years ago

This seemed sensible enough to me and helped performance a little in my case.

andyferris commented 2 years ago

Thanks @simeonschaub - this looks great.

codecov[bot] commented 2 years ago

Codecov Report

Merging #74 (b5ce237) into master (8527171) will increase coverage by 0.07%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
+ Coverage   76.08%   76.16%   +0.07%     
==========================================
  Files          19       19              
  Lines        1974     1980       +6     
==========================================
+ Hits         1502     1508       +6     
  Misses        472      472
Impacted Files Coverage Δ
src/Dictionary.jl 74.56% <100.00%> (+0.29%) :arrow_up:
src/Indices.jl 88.25% <100.00%> (+0.14%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8527171...b5ce237. Read the comment docs.