search

andyferris / Dictionaries.jl

An alternative interface for dictionaries in Julia, for improved productivity and performance
Other
282 stars 28 forks source link

Fix invariance of `convert` for `Dictionary` #79

Closed serenity4 closed 2 years ago

serenity4 commented 2 years ago

Adding the convert method from #67 seems to have broken convert(::Type{T}, x::T) = x, which led to problems because the identity of a given dictionary was not maintained.

codecov[bot] commented 2 years ago

Codecov Report

Merging #79 (877b8bf) into master (7779d1c) will decrease coverage by 0.03%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
- Coverage   76.16%   76.12%   -0.04%     
==========================================
  Files          19       19              
  Lines        1980     1981       +1     
==========================================
  Hits         1508     1508              
- Misses        472      473       +1
Impacted Files Coverage Δ
src/Dictionary.jl 74.13% <100.00%> (-0.43%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7779d1c...877b8bf. Read the comment docs.