Make diffing stack safe

andyglow / scala-xml-diff

Scala XML Diff

GNU Lesser General Public License v3.0

9 stars 7 forks source link

Make diffing stack safe #15

Closed mrdziuban closed 2 years ago

mrdziuban commented 3 years ago

Fixes #14

Adds minimal version of cats.Eval which guarantees stack safety when using map/flatMap
Updates all methods in XmlDiffComputer to wrap their results in Eval
Sets the JVM stack size when running tests to 256K and adds a test to verify that diffing elements with a lot of children does not throw a StackOverflowError

mrdziuban commented 2 years ago

@andyglow is there any chance you could review this and potentially release a new version if/when it's merged? Let me know if there's any more info or clarification I can provide

andyglow commented 2 years ago

No, no questions.. This looks great. Thank you for your contribution. Except... May I ask you to hide Eval machinery making it a package private?

mrdziuban commented 2 years ago

Sure thing @andyglow, just pushed another commit to add private[diff]

andyglow commented 2 years ago

hey @mrdziuban 3.0.1 has been published to sonatype should be available in maven central soon

mrdziuban commented 2 years ago

Thank you!