Npm symbols missing after update

atiris commented 9 months ago

After updating of:

    "express": "^4.18.2",
    "rxjs": "~7.8.0",
    "tslib": "^2.3.0",
    "zone.js": "~0.14.2"

versions, set by this extension, are now without any symbols (even if there is no change in version):

    "express": "4.18.2",
    "rxjs": "7.8.1",
    "tslib": "2.6.2",
    "zone.js": "0.14.2"

Symbols should be kept as they represent what versions I want to install in the future. Expected result is:

    "express": "^4.18.2",
    "rxjs": "~7.8.1",
    "tslib": "^2.6.2",
    "zone.js": "~0.14.2"

andygongea commented 9 months ago

Thanks, Jozef for your email. 🤗 I will fix that.

On Sat, Dec 2, 2023 at 3:32 PM Jozef Pažin @.***> wrote:

After updating of:
"express": "^4.18.2",
"rxjs": "~7.8.0",
"tslib": "^2.3.0",
"zone.js": "~0.14.2"
versions, set by this extension, are now without any symbols (even if there is no change in version):
"express": "4.18.2",
"rxjs": "7.8.1",
"tslib": "2.6.2",
"zone.js": "0.14.2"
Symbols should be kept as they represent what versions I want to install in the future. Expected result is:
"express": "^4.18.2",
"rxjs": "~7.8.1",
"tslib": "^2.6.2",
"zone.js": "~0.14.2"
— Reply to this email directly, view it on GitHub https://github.com/andygongea/update-now/issues/2, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGH45L74HF4W5ZCTKMQTI3YHMUXRAVCNFSM6AAAAABAEASP7WVHI2DSMVQWIX3LMV43ASLTON2WKOZSGAZDEMBUGIYDSNA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Andy Gongea - Lead Product Designer +40761321885 Craiova, 200096, Romania [image: https://facebook.com/andy.gongea] https://facebook.com/andy.gongea [image: https://twitter.com/andygongea] https://twitter.com/andygongea [image: https://linkedin.com/in/andygongea] https://linkedin.com/in/andygongea [image: https://dribbble.com/andygongea] https://dribbble.com/andygongea

andygongea commented 9 months ago

Just released a new version of the plugin @atiris, addressing this issue.

atiris commented 9 months ago

Still some bugs. My package.json has this dependencies:

  "dependencies": {
    "@angular/animations": "^17.0.4",
    "@angular/common": "^17.0.4",
    "@angular/compiler": "^17.0.4",
    "@angular/core": "^17.0.4",
    "@angular/forms": "^17.0.4",
    "@angular/platform-browser": "^17.0.4",
    "@angular/platform-browser-dynamic": "^17.0.4",
    "@angular/platform-server": "^17.0.4",
    "@angular/router": "^17.0.4",
    "@angular/ssr": "^17.0.3",
    "express": "^4.18.2",
    "rxjs": "~7.8.0",
    "tslib": "^2.3.0",
    "zone.js": "~0.14.2"
  },

After click on @angular/animations -> 17.0.5 (patch) symbol is still removed. Result:

"@angular/animations": "17.0.5",

After click on Update Now: 11 updates available (... Result is:

  "dependencies": {
    "@angular/animations": "^17.0.5",
    "@angular/common": "^17.0.5",
    "@angular/compiler": "^17.0.5",
    "@angular/core": "^17.0.5",
    "@angular/forms": "^17.0.5",
    "@angular/platform-browser": "^17.0.5",
    "@angular/platform-browser-dynamic": "^17.0.5",
    "@angular/platform-server": "^17.0.5",
    "@angular/router": "^17.0.5",
    "@angular/ssr": "^17.0.5",
    "express": "4.18.2",
    "rxjs": "~7.8.1",
    "tslib": "^2.6.2",
    "zone.js": "0.14.2"
  },

So, you can see, for @angular/animations your change works, but for "express": "4.18.2", "^" is again removed. The same for "~" in zone.js package.

I can see that the problem is likely to be that these packages do not need to be updated according to the initial load. So your fix probably doesn't solve the cases where using Update Now some packages are not updated and their versions should not be changed.

In order to use this plugin regularly, I also need the "devDependencies" update, if you want, I can create another request for that.

andygongea / update-now

Npm symbols missing after update #2