search

andygruber / songseeker-hitster-playlists

CSV files containing Youtube links to the Hitster playing cards
MIT License
5 stars 4 forks source link

Add Hitster nordics, Finland edition data #16

Closed lukkarm1 closed 4 months ago

lukkarm1 commented 4 months ago

This PR adds Hitster nordics, Finland edition data.

On the surface level, everything should be correct, and I have corrected some incorrect items spotted when playtesting, but that has not been in any way exhaustive test of the dataset.

andygruber commented 4 months ago

This PR adds Hitster nordics, Finland edition data.

On the surface level, everything should be correct, and I have corrected some incorrect items spotted when playtesting, but that has not been in any way exhaustive test of the dataset.

ty for addition, I have no way to check, that is why I have 2 questions:

lukkarm1 commented 4 months ago

Yes, I created the PR (now merged), which added the rule that will correctly resolve to this csv file if Nordic version is scanned.For the numbering, I think that the Nordic countries share the same base URL, so the card number range is larger and spotty for each. "Original" songs seems to be in the lower numbers, the Finnish songs seem to be located around 1100 range, and, I did a quick test and created link using card number 1201 which then resolved to Swedish artist's musicOn Jun 21, 2024 02:12, Andreas Gruber @.***> wrote:

This PR adds Hitster nordics, Finland edition data. On the surface level, everything should be correct, and I have corrected some incorrect items spotted when playtesting, but that has not been in any way exhaustive test of the dataset.

ty for addition, I have no way to check, that is why I have 2 questions: the links get resolved by songseeker to that csv filename?the card numbers are really not increasing from 1 to 308 like in the other versions?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

andygruber commented 4 months ago

Hosted version is now updated to to include this as well