Closed opalmer closed 8 years ago
@andygrunwald, thoughts?
Good idea. Go for it! The only important note from my side: Release notes. These release notes should add value and answer questions like "What is new? What bugs were fixed? Why should i upgrade? Any breaking changes for the upgrade and do i have to adjust my code?"
Personally i like the release notes from etcd, see https://github.com/coreos/etcd/releases They are useful, clear and well structured.
@opalmer Afaik you own the rights to do releases and tags. If not ping me and i will grant those to you. Othwerwise: Good idea :)
Will you handle this ticket and close once a release is done?
Done! It's pretty close to what etcd does though not exactly (we don't have a NEWS file yet). For my own project, I made it a policy to update the changelog for every new PR, we probably could do the same here.
Awesome work. Thank you. Regarding the changelog: Yes, why not :)
So after using go-gerrit for a while I've been starting to think we should be tagging releases. There's a few reasons for this:
GetReflog
can takefrom
andto
url parameters but the current implementation of go-gerrit does not support this. The change could be made in master now but it would be a breaking change and it does not feel appropriate to make a new function.