search

andygrunwald / go-gerrit

Go client/library for Gerrit Code Review
https://godoc.org/github.com/andygrunwald/go-gerrit
MIT License
96 stars 40 forks source link

Make _account_id optional in AccountInfo #19

Closed opalmer closed 8 years ago

opalmer commented 8 years ago

This should address #16.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 10.495% when pulling 8a94d7f2ceecfd287c65a335edd838410b84609a on fix_account_id into bbeff443c0f04ad01e9c71391237764c25a9173e on master.

opalmer commented 8 years ago

@perolausson would you mind taking a look? I think this addresses what you brought up in #16 but I wanted to be sure before it's merged.

perolausson commented 8 years ago

I'll try it out later this evening!

On 12 Oct 2016 16:36, "opalmer" notifications@github.com wrote:

@perolausson https://github.com/perolausson would you mind taking a look? I think this addresses what you brought up in #16 https://github.com/andygrunwald/go-gerrit/issues/16 but I wanted to be sure before it's merged.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/andygrunwald/go-gerrit/pull/19#issuecomment-253249439, or mute the thread https://github.com/notifications/unsubscribe-auth/AC2X-ORCyPpjqFHeI68xTxgYFZEG-6Ynks5qzP5xgaJpZM4KU5P8 .

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 10.495% when pulling be7a4afb12239f32552742b566b49f8946322132 on fix_account_id into 075ba1bedb0972ba8a16c3952a07fd4d78152144 on master.

andygrunwald commented 8 years ago

LGTM