search

andygrunwald / go-gerrit

Go client/library for Gerrit Code Review
https://godoc.org/github.com/andygrunwald/go-gerrit
MIT License
96 stars 40 forks source link

Support Custom Labels #29

Closed opalmer closed 8 years ago

opalmer commented 8 years ago

This is a small but breaking change to support labels other than Code-Review and Verified.

See #21 for a full discussion.

codecov-io commented 8 years ago

Current coverage is 17.32% (diff: 100%)

Merging #29 into master will not change coverage

@@             master        #29   diff @@
==========================================
  Files            20         20          
  Lines          1709       1709          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            296        296          
  Misses         1386       1386          
  Partials         27         27

Powered by Codecov. Last update bb51cd9...cefbfcb

opalmer commented 8 years ago

@andygrunwald / @andygrunwald, please have a look. I'm going to switch one of my projects over to this branch to continue testing but so far this seems to work like we discussed.

andygrunwald commented 8 years ago

@opalmer Looks like a small and easy change. Go ahead when you are done with your testing.

opalmer commented 8 years ago

Have not had any issues with this since I created the PR, merging.