search

andygrunwald / go-gerrit

Go client/library for Gerrit Code Review
https://godoc.org/github.com/andygrunwald/go-gerrit
MIT License
96 stars 40 forks source link

update PublishChangeEdit: notify param #31

Closed banksean closed 7 years ago

banksean commented 7 years ago

This fixes a 400 I was getting when calling PublishChangeEdit on chromium-review.googlesource.com. It told me it expected a json body, so this adds one.

codecov-io commented 7 years ago

Codecov Report

Merging #31 into master will decrease coverage by 0.02%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
- Coverage   17.32%   17.29%   -0.03%     
==========================================
  Files          20       20              
  Lines        1709     1711       +2     
==========================================
  Hits          296      296              
- Misses       1386     1388       +2     
  Partials       27       27
Impacted Files Coverage Δ
changes_edit.go 0% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6807790...653e169. Read the comment docs.

banksean commented 7 years ago

The coverage reports confuse me. I don't think I changed the lines it's highlighting in this PR.

andygrunwald commented 7 years ago

Thanks a lot!