andygrunwald / go-gerrit

Go client/library for Gerrit Code Review

https://godoc.org/github.com/andygrunwald/go-gerrit

MIT License

96 stars 40 forks source link

Updated S parameter according to the Gerrit API #48

Closed michaeldorner closed 3 years ago

michaeldorner commented 6 years ago

changed all occurrences of the S parameter according to the Gerrit API ("The S or start query parameter can be supplied to skip a number of changes from the list.")

codecov-io commented 6 years ago

Codecov Report

Merging #48 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #48   +/-   ##
=======================================
  Coverage   21.23%   21.23%           
=======================================
  Files          21       21           
  Lines        1775     1775           
=======================================
  Hits          377      377           
  Misses       1353     1353           
  Partials       45       45

Impacted Files	Coverage Δ
changes.go	`16.14% <ø> (ø)`
projects.go	`17.43% <ø> (ø)`
projects_branch.go	`0.00% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8fdb823...0f32319. Read the comment docs.

andygrunwald commented 4 years ago

Hey @michaeldorner, any news on this? Anything I can help with?

michaeldorner commented 4 years ago

Sorry for the delay and even more sorry for forgetting about it. I will fix it as soon as possible (hopefully on the weekend).

michaeldorner commented 4 years ago

With the current solution, go-gerrit checks if Skip and Start are conflicting:

Both zero or the same value are fine
Either one parameter is 0 (default case)

The other skip parameters I changed accordingly to the documentation: There is not start parameter for projects.go and projects_branches.go.

What do you think?

andygrunwald commented 4 years ago

@dmitshur @opalmer Any opinions on this? What do you think?

andygrunwald commented 3 years ago

Maybe I made an implementation mistake with https://github.com/andygrunwald/go-gerrit/commit/101051e002059e0c8c3143008b47108daf483a60 because of https://github.com/andygrunwald/go-gerrit/pull/48

I will fix this in the next days and add proper testing.

andygrunwald commented 3 years ago

Thanks a lot, @michaeldorner for your work on this. I picked this up, tested it through, and added a bit more stuff around it. The "new version" is available in https://github.com/andygrunwald/go-gerrit/pull/98

I will close this and we continue in https://github.com/andygrunwald/go-gerrit/pull/98. If you disagree and you think there is more on this PR, let me know and I will re-open it.