[bug] Jira Server user search API triggers 404 error with accountID

[kopytovs]

Describe the bug

Current Jira Server API has user search method which unavailable after https://github.com/andygrunwald/go-jira/commit/f50cb07b297d79138b13e5ab49ea33965d32f5c1

To Reproduce

1. Use Jira Server API
2. Try to search user with accoundID user, _, error := client.User.Get(accountID)
3. Catch error Either the 'username' or the 'key' query parameters need to be provided: request failed. Please analyze the request body for more details. Status code: 404

Expected behavior

No reproduce 404 error with valid request

https://docs.atlassian.com/software/jira/docs/api/REST/8.9.0/#api/2/user-findUsers

Possible Solution

Add both (Cloud and Server) compatibility

Your Environment

Include as many relevant details about the environment you experienced the problem in

• go-jira version (git tag or sha): https://github.com/andygrunwald/go-jira/commit/de60bbed3f0c62e5933c8927cddf1d4a7ee20f75
• Go version (go version): v1.14.4
• Jira version: v8.5.3
• Jira type (cloud or on-premise): Server
• Operating System and version: macOS 10.15.4

[github-actions[bot]]

Hi! Thank you for taking the time to create your first issue! Really cool to see you here for the first time. Please give us a bit of time to review it.

[ghostsquad]

We are currently working on V2 which will have better compatibility between server and cloud versions.

[kopytovs]

@ghostsquad 👍

[ghostsquad]

In the mean time, if you have some ideas on how to fix this issue, we happily accept PRs!

[ghostsquad]

I think the solution is to implement a new method like GetByUsername, which would have the old code prior to the "bugfix" which apparently only fixed cloud versions, but broke server versions.

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.