feat: add UpdateIssueWithOptions - Githubissues

andygrunwald / go-jira

Go client library for Atlassian Jira

https://pkg.go.dev/github.com/andygrunwald/go-jira?tab=doc

MIT License

1.47k stars 469 forks source link

feat: add UpdateIssueWithOptions #658

Open RichardoC opened 7 months ago

RichardoC commented 7 months ago

and add testing for addOptions to make clear what it does

What type of PR is this?

feature

What this PR does / why we need it:

Added an equivalent to func (*IssueService) UpdateWithOptions for just issue patches
added some testing coverages to addOptions to help show how it works and
Fixes a bug where "NotifyUsers: false" would not get sent to the server due to omit empty, and empty for booleans are false. This may be present in other fields but just focussed on fixing my own issue
Fixes all boolean options to avoid repeats of this bug

Which issue(s) this PR fixes:

Special notes for your reviewer:

Additional documentation e.g., usage docs, etc.:

RichardoC commented 7 months ago

I'd love a patch release to be made including this, as it means I can send thousands fewer emails a day from automation that noone wants to read

RichardoC commented 7 months ago

Credit to @chrisnovakovic for finding this fix in https://github.com/thought-machine/go-jira/commit/3870a803d29759644d295bfe52cf0005d9d1fb8b