search

andyhmltn / ember-js-chatapp

MIT License
3 stars 1 forks source link

Two of the current user in the 'Online Users' section #1

Closed andyhmltn closed 11 years ago

andyhmltn commented 11 years ago

For some reason, the most recent user appears twice in the 'Online Users' section of the application.

zspecza commented 11 years ago

Did some CLI debugging and we can rule out Redis as the cause of the problem - Redis only stores one instance within the list. Applies to #9 as well. Closer to the source of the problem we are ;)

andyhmltn commented 11 years ago

Turns out this was a relatively simple bug.

zspecza commented 11 years ago

What was causing it?

andyhmltn commented 11 years ago

I'm not exactly sure. Moving the current_users.push into the part that cycles through and adds it to redis seemed to fix it.

zspecza commented 11 years ago

Ah. I should've sent a pull request in sooner before you fixed this cause I changed a LOT.

andyhmltn commented 11 years ago

Send one over and I'll try and add those fixes :p

zspecza commented 11 years ago

Done

andyhmltn commented 11 years ago

You're right, there was a quite a few changes! A tonne of rebasing later: Merged