search

andyhmltn / ember-js-chatapp

MIT License
3 stars 1 forks source link

Develop #10

Closed zspecza closed 11 years ago

zspecza commented 11 years ago

App.js had over 100 JSLint failing errors on it, I fixed all of those. Removed Heroku formatting options for socket configuration Added scroll-height to the chat view as a temporary scrollbar fix After looking at a lot of Ember.js projects, it is becoming a slow standard to always name your app object 'App' because it promotes reusable code - code that can be specific to a single project, but does not have to be.

andyhmltn commented 11 years ago

Right. After a bit of wrestling git, I've managed to merge these into the main repo. Thanks! There's a few differences:

I've squashed a few different commits into one (The annoying newline ones) and removed the 'debug scrollbar' commit (I fixed this before you pull requested.)

zspecza commented 11 years ago

Awesome. So a lot of the bugs are now squashed. Yay for combined efforts, lol.

andyhmltn commented 11 years ago

Horray! Haha. I've added a new milestone on the last few issues.

zspecza commented 11 years ago

There are still a few issues that come to mind that haven't been opened just yet :P

andyhmltn commented 11 years ago

Well open away! haha