search

andyholmes / valent

Connect, control and sync devices
https://valent.andyholmes.ca
Other
510 stars 16 forks source link

Media Player interface doesn't distinguish between local and remote players #639

Open vixalien opened 3 months ago

vixalien commented 3 months ago

Current Behavior

When I pair & connect Valent to my Android device running KDE Connect on my phone, I can view players exposed by Valent through the KDE Connect protocol.

The issue is that when I open Valent on my PC, it also sees players from the phone.

Let me explain this in more detail by giving an example,

on my phone (KDE Connect)

I have two apps playing music:

on my PC (Valent)

I have one app playing music:

Observation

On my phone, I will see the two players (YouTube Music & Apple music) + the one exposed by Valent (Muzika)

If I go on my PC, Valent will see three players from the Android phone, i.e. YouTube Music, Apple Music & Muzika. Note that it sees Muzika as a player from the phone, even though it's a player from itself.

Expected Behavior

I woud expect only the sources from the app to be shown (not other sources exposed by KDE Connect on the phone)

Desktop

GNOME Shell

Other Desktop

No response

Operating System

Alpine

Installed from

Nightly Flatpak

Version

1.0.0.alpha

Devices

KDE Connect (Android)

Plugins

No response

Logs

No response

Screenshots

No response

andyholmes commented 3 months ago

How can you tell it's seeing Muzika as a player from the phone? Wouldn't that mean you should have 4 players on your desktop?

vixalien commented 3 months ago

When I click on the player from the GNOME panel, I'm taken to a screen which shows players exposed by Valent.

It shows: Google, YouTube Music and Muzika.

The Muzika source is actually exposed by KDE Connect on the mobile phone.

andyholmes commented 3 months ago

Ah, that's a list of all media players known to Valent, including local players. Probably we should clarify that in the user interface then.