search

andyjac / top_10_albums

Displays top 10 albums for a highlighted musical artist in the browser
0 stars 0 forks source link

Loggin' #14

Closed bion closed 9 years ago

bion commented 9 years ago

Log everything, always. Log every request you get from the client and every response you get from lastfm. Start logging less only when it becomes a performance issue. lggin

andyjac commented 9 years ago

Word.

Fantastic picture!

bion commented 9 years ago

Be sure to include an easily searchable keyword for each type of log, as well as a timestamp. This will make it easy to answer questions like "how many requests were made in the last week?" by using simple command line tools like grep.

bion commented 9 years ago

also, make the timestamp easy to parse, as oppose to human readable.

bion commented 9 years ago

Also, to follow up on the "only log less when it becomes a performance issue", the solution there is usually to build out a logging service or buy logging service from a company that specializes in it (like Splunk or Loggly) instead of turning down the log levels.

andyjac commented 9 years ago

cool. know of any examples that show good logging practices?

bion commented 9 years ago

uhhh not off the top of my head, you can try googling.

bion commented 9 years ago

for now i don't think you need to bother with any of the really heavy-weight tools out there like winston or bunyan. but they're good to know about.

andyjac commented 9 years ago

okay cool. yeah, i'm googling stuff now.

On Tue, Nov 18, 2014 at 2:47 PM, Bion Johnson notifications@github.com wrote:

for now i don't think you need to bother with any of the really heavy-weight tools out there like winston or bunyan. but they're good to know about.

— Reply to this email directly or view it on GitHub https://github.com/andyjac/lastfm_top_albums/issues/14#issuecomment-63560371 .

andyjac commented 9 years ago

Done.