andyjsmith / SmugMug-Downloader

Download all the images from a SmugMug user
48 stars 20 forks source link

Images downloaded does not have the GPS Data #17

Closed hongning123 closed 10 months ago

hongning123 commented 11 months ago

I found downloaded images does not have the GPS Data that the original pic have. Looking thru your code I notice you use the LargestImage, is there a reason why you didn't use ImageDownload. ImageDownload seems to download the original pic with the GPS data. I am thinking I am missing something.

andyjsmith commented 10 months ago

Where do you see "ImageDownload"? I don't see that anywhere in the API spec, but I also haven't worked with it for a long time. Can you provide a publicly-accessible example?

andyjsmith commented 10 months ago

I don't see that, see below. I'm guessing based on your username that this is your own album. So I bet that's only available if you're logged in and you're the owner of the album. (In that case -- you should be able to download the album yourself on the Smugmug website, you shouldn't need to use this tool)

"Uris": {
    "LargestImage": {
        "Uri": "/api/v2/image/RdXNChX-0!largestimage",
        "Locator": "LargestImage",
        "LocatorType": "Object",
        "UriDescription": "Largest size available for image",
        "EndpointType": "LargestImage"
    },
    "ImageSizes": {
        "Uri": "/api/v2/image/RdXNChX-0!sizes",
        "Locator": "ImageSizes",
        "LocatorType": "Object",
        "UriDescription": "Sizes available for image",
        "EndpointType": "ImageSizes"
    },
    "ImageSizeDetails": {
        "Uri": "/api/v2/image/RdXNChX-0!sizedetails",
        "Locator": "ImageSizeDetails",
        "LocatorType": "Object",
        "UriDescription": "Detailed size information for image",
        "EndpointType": "ImageSizeDetails"
    },
    "PointOfInterest": {
        "Uri": "/api/v2/image/RdXNChX-0!pointofinterest",
        "Locator": "PointOfInterest",
        "LocatorType": "Object",
        "UriDescription": "Point of interest for image",
        "EndpointType": "PointOfInterest"
    },
    "PointOfInterestCrops": {
        "Uri": "/api/v2/image/RdXNChX-0!poicrops",
        "Locator": "PointOfInterestCrops",
        "LocatorType": "List",
        "UriDescription": "PointOfInterest Crops for image",
        "EndpointType": "PointOfInterestCrops"
    },
    "Regions": {
        "Uri": "/api/v2/image/RdXNChX-0!regions",
        "Locator": "Region",
        "LocatorType": "Objects",
        "UriDescription": "Regions for image",
        "EndpointType": "Regions"
    },
    "ImageComments": {
        "Uri": "/api/v2/image/RdXNChX-0!comments",
        "Locator": "Comment",
        "LocatorType": "Objects",
        "UriDescription": "Comments on image",
        "EndpointType": "ImageComments"
    },
    "ImageMetadata": {
        "Uri": "/api/v2/image/RdXNChX-0!metadata",
        "Locator": "ImageMetadata",
        "LocatorType": "Object",
        "UriDescription": "Metadata for image",
        "EndpointType": "ImageMetadata"
    },
    "ImagePrices": {
        "Uri": "/api/v2/image/RdXNChX-0!prices",
        "Locator": "CatalogSkuPrice",
        "LocatorType": "Objects",
        "UriDescription": "Purchasable Skus",
        "EndpointType": "ImagePrices"
    },
    "ImagePricelistExclusions": {
        "Uri": "/api/v2/image/RdXNChX-0!pricelistexclusions",
        "Locator": "ImagePricelistExclusions",
        "LocatorType": "Object",
        "UriDescription": "Pricelist information for an image",
        "EndpointType": "ImagePricelistExclusions"
    },
    "Album": {
        "Uri": "/api/v2/album/dCR8Zd",
        "Locator": "Album",
        "LocatorType": "Object",
        "UriDescription": "Album by key",
        "EndpointType": "Album"
    },
    "Image": {
        "Uri": "/api/v2/image/RdXNChX-0",
        "Locator": "Image",
        "LocatorType": "Object",
        "UriDescription": "Image by key",
        "EndpointType": "Image"
    },
    "AlbumImagePricelistExclusions": {
        "Uri": "/api/v2/album/dCR8Zd/image/RdXNChX-0!pricelistexclusions",
        "Locator": "AlbumImagePricelistExclusions",
        "LocatorType": "Object",
        "UriDescription": "Pricelist information for an album image",
        "EndpointType": "AlbumImagePricelistExclusions"
    },
    "AlbumImageMetadata": {
        "Uri": "/api/v2/album/dCR8Zd/image/RdXNChX-0!metadata",
        "Locator": "AlbumImageMetadata",
        "LocatorType": "Object",
        "UriDescription": "Metadata for AlbumImage",
        "EndpointType": "AlbumImageMetadata"
    },
    "AlbumImageShareUris": {
        "Uri": "/api/v2/album/dCR8Zd/image/RdXNChX-0!shareuris",
        "Locator": "AlbumImageShareUris",
        "LocatorType": "Object",
        "UriDescription": "URIs that are useful for sharing",
        "EndpointType": "AlbumImageShareUris"
    }
},
hongning123 commented 10 months ago

true its my own album, i use it as ,the download of smugmug is tedious. i had to use sessionid to make it work. so you are right if your not the owner i believe likelihood you wont have access to original pictures. i just preferred the original as it has the gps attribute. Thanks for explaining.

On Mon, Nov 20, 2023, 5:17 PM Andy Smith @.***> wrote:

I don't see that, see below. I'm guessing based on your username that this is your own album. So I bet that's only available if you're logged in and you're the owner of the album. (In that case -- you should be able to download the album yourself on the Smugmug website, you shouldn't need to use this tool)

"Uris": { "LargestImage": { "Uri": "/api/v2/image/RdXNChX-0!largestimage", "Locator": "LargestImage", "LocatorType": "Object", "UriDescription": "Largest size available for image", "EndpointType": "LargestImage" }, "ImageSizes": { "Uri": "/api/v2/image/RdXNChX-0!sizes", "Locator": "ImageSizes", "LocatorType": "Object", "UriDescription": "Sizes available for image", "EndpointType": "ImageSizes" }, "ImageSizeDetails": { "Uri": "/api/v2/image/RdXNChX-0!sizedetails", "Locator": "ImageSizeDetails", "LocatorType": "Object", "UriDescription": "Detailed size information for image", "EndpointType": "ImageSizeDetails" }, "PointOfInterest": { "Uri": "/api/v2/image/RdXNChX-0!pointofinterest", "Locator": "PointOfInterest", "LocatorType": "Object", "UriDescription": "Point of interest for image", "EndpointType": "PointOfInterest" }, "PointOfInterestCrops": { "Uri": "/api/v2/image/RdXNChX-0!poicrops", "Locator": "PointOfInterestCrops", "LocatorType": "List", "UriDescription": "PointOfInterest Crops for image", "EndpointType": "PointOfInterestCrops" }, "Regions": { "Uri": "/api/v2/image/RdXNChX-0!regions", "Locator": "Region", "LocatorType": "Objects", "UriDescription": "Regions for image", "EndpointType": "Regions" }, "ImageComments": { "Uri": "/api/v2/image/RdXNChX-0!comments", "Locator": "Comment", "LocatorType": "Objects", "UriDescription": "Comments on image", "EndpointType": "ImageComments" }, "ImageMetadata": { "Uri": "/api/v2/image/RdXNChX-0!metadata", "Locator": "ImageMetadata", "LocatorType": "Object", "UriDescription": "Metadata for image", "EndpointType": "ImageMetadata" }, "ImagePrices": { "Uri": "/api/v2/image/RdXNChX-0!prices", "Locator": "CatalogSkuPrice", "LocatorType": "Objects", "UriDescription": "Purchasable Skus", "EndpointType": "ImagePrices" }, "ImagePricelistExclusions": { "Uri": "/api/v2/image/RdXNChX-0!pricelistexclusions", "Locator": "ImagePricelistExclusions", "LocatorType": "Object", "UriDescription": "Pricelist information for an image", "EndpointType": "ImagePricelistExclusions" }, "Album": { "Uri": "/api/v2/album/dCR8Zd", "Locator": "Album", "LocatorType": "Object", "UriDescription": "Album by key", "EndpointType": "Album" }, "Image": { "Uri": "/api/v2/image/RdXNChX-0", "Locator": "Image", "LocatorType": "Object", "UriDescription": "Image by key", "EndpointType": "Image" }, "AlbumImagePricelistExclusions": { "Uri": "/api/v2/album/dCR8Zd/image/RdXNChX-0!pricelistexclusions", "Locator": "AlbumImagePricelistExclusions", "LocatorType": "Object", "UriDescription": "Pricelist information for an album image", "EndpointType": "AlbumImagePricelistExclusions" }, "AlbumImageMetadata": { "Uri": "/api/v2/album/dCR8Zd/image/RdXNChX-0!metadata", "Locator": "AlbumImageMetadata", "LocatorType": "Object", "UriDescription": "Metadata for AlbumImage", "EndpointType": "AlbumImageMetadata" }, "AlbumImageShareUris": { "Uri": "/api/v2/album/dCR8Zd/image/RdXNChX-0!shareuris", "Locator": "AlbumImageShareUris", "LocatorType": "Object", "UriDescription": "URIs that are useful for sharing", "EndpointType": "AlbumImageShareUris" } },

— Reply to this email directly, view it on GitHub https://github.com/andyjsmith/SmugMug-Downloader/issues/17#issuecomment-1820060091, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALMUOATW6ZEZA3UR5PZB6WTYFP6KZAVCNFSM6AAAAAA7E4PPZSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRQGA3DAMBZGE . You are receiving this because you authored the thread.Message ID: @.***>

andyjsmith commented 10 months ago

Can you try the dev branch here and let me know if that fixed it for you? I don't have a SM account so I can't test. https://github.com/andyjsmith/SmugMug-Downloader/tree/dev

hongning123 commented 10 months ago

I will try that.

On Mon, Nov 20, 2023, 5:52 PM Andy Smith @.***> wrote:

Can you try the dev branch here and let me know if that fixed it for you? I don't have a SM account so I can't test. https://github.com/andyjsmith/SmugMug-Downloader/tree/dev

— Reply to this email directly, view it on GitHub https://github.com/andyjsmith/SmugMug-Downloader/issues/17#issuecomment-1820087748, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALMUOAX3SNVTDIQQ7H3IYOTYFQCPBAVCNFSM6AAAAAA7E4PPZSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRQGA4DONZUHA . You are receiving this because you authored the thread.Message ID: @.***>

hongning123 commented 10 months ago

Yep it's working if you have rights to it (session id) it will do ImageDownload else's LargestImage. Thanks

On Mon, Nov 20, 2023 at 5:52 PM Andy Smith @.***> wrote:

Can you try the dev branch here and let me know if that fixed it for you? I don't have a SM account so I can't test. https://github.com/andyjsmith/SmugMug-Downloader/tree/dev

— Reply to this email directly, view it on GitHub https://github.com/andyjsmith/SmugMug-Downloader/issues/17#issuecomment-1820087748, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALMUOAX3SNVTDIQQ7H3IYOTYFQCPBAVCNFSM6AAAAAA7E4PPZSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRQGA4DONZUHA . You are receiving this because you authored the thread.Message ID: @.***>

andyjsmith commented 10 months ago

Fixed #19