Open AnakinFoxe opened 4 months ago
Sorry for the late reply, I appreciate the changes!
I'm a bit hesitant on the password authentication due to some unhandled edge cases (e.g. what if the user has 2FA enabled?). Maybe we could keep both the user/pass and session token auth mechanisms instead of replacing it. As for the Makefile, I would like to keep this script platform-independent so I don't want to merge in a Unix-specific script. At some point a setup.py / pyproject.toml may be appropriate.
The other contributions are great but they probably need to be split off as separate PRs.
@andyjsmith thanks for the comments! I have updated the PR with following changes (updated the PR description as well)
-s SESSION
argument. If session ID is provided, password will be ignored.
First of all, thanks for this great script. It helped me download all the albums for my kid 😆
Made a few changes to the original code:
-p PASSWORD
option), however if session ID is provided, password will be ignored.--folder
to download all the albums under the specific folderSmugMugDownloader
logging
@retry
to manage retry forget_json()
UseMakefile
to setup a virtual environment to work with