andyjsmith / SmugMug-Downloader

Download all the images from a SmugMug user
47 stars 19 forks source link

A few changes to the original code #23

Open AnakinFoxe opened 4 months ago

AnakinFoxe commented 4 months ago

First of all, thanks for this great script. It helped me download all the albums for my kid 😆

Made a few changes to the original code:

andyjsmith commented 1 month ago

Sorry for the late reply, I appreciate the changes!

I'm a bit hesitant on the password authentication due to some unhandled edge cases (e.g. what if the user has 2FA enabled?). Maybe we could keep both the user/pass and session token auth mechanisms instead of replacing it. As for the Makefile, I would like to keep this script platform-independent so I don't want to merge in a Unix-specific script. At some point a setup.py / pyproject.toml may be appropriate.

The other contributions are great but they probably need to be split off as separate PRs.

AnakinFoxe commented 3 weeks ago

@andyjsmith thanks for the comments! I have updated the PR with following changes (updated the PR description as well)