andykarpov / PT2314

Arduino library to control PT2314 AKA ET2314 audio processor
12 stars 13 forks source link

Improve error handling so the init() method will return true or false #4

Closed wmarkow closed 6 years ago

wmarkow commented 6 years ago

It would be good if init() method will return false when there are some hardware issues with I2C communication to PT2314. Currently the init() method returns always 1 (which I think is meant to be success). I was thinking that it could return the error code from the Wire library:

I propose at the beginning to return true or false from the init() method. This solution helped me a lot when investigation #3.

wmarkow commented 6 years ago

I see that pull request #5 has been merged. I'm closing this issue.