search

andykirk / CKEditorFootnotes

Footnotes plugin for CKEditor
17 stars 22 forks source link

footnotes in wrong instance #1

Closed urs63 closed 10 years ago

urs63 commented 10 years ago

Hi Andy.We are using your footnote plugin. Thank you for your efforts. We have the problem that we are using up to 10 instances of ckeditor on one page. When we are inserting a footnote, it will be inserted in the last instance and not in the one we triggered the plugin. Any ideas? Thanks Urs

andykirk commented 10 years ago

Hi, Thanks for the feedback. I hadn't really tested this with multiple instances, but the plugin creates a section with an id of 'footnotes'. id's are supposed to be unique so I guess jquery is selected the last one. I'll have a go at making sure the footnotes section has a unique id by appending the editor id or some such.

I'll do this as soon as I can and test it.

Thanks.

urs63 commented 10 years ago

Hi Andy

Thank you very much!

Von: andykirk [mailto:notifications@github.com] Gesendet: Dienstag, 5. August 2014 13:14 An: andykirk/CKEditorFootnotes Cc: Urs Stadelmann Betreff: Re: [CKEditorFootnotes] footnotes in wrong instance (#1)

Hi, Thanks for the feedback. I hadn't really tested this with multiple instances, but the plugin creates a section with an id of 'footnotes'. id's are supposed to be unique so I guess jquery is selected the last one. I'll have a go at making sure the footnotes section has a unique id by appending the editor id or some such.

I'll do this as soon as I can and test it.

Thanks.

— Reply to this email directly or view it on GitHubhttps://github.com/andykirk/CKEditorFootnotes/issues/1#issuecomment-51183269.

andykirk commented 10 years ago

Actually, come to think of it, the #footnotes section is inside an iframe, so it's uniqueness shouldn't be a problem - it must be something else.

andykirk commented 10 years ago

Hi, I've hurriedly fixed this, so it may not be perfect - let me know.

I've issued a new release here on Github, but also on the CKEditor site.

urs63 commented 10 years ago

Thanks. I just was testing if I have a problem in my site. It did not look like.

I will inform you tomorrow - I have to leave now.

See you

Von: andykirk [mailto:notifications@github.com] Gesendet: Dienstag, 5. August 2014 14:06 An: andykirk/CKEditorFootnotes Cc: Urs Stadelmann Betreff: Re: [CKEditorFootnotes] footnotes in wrong instance (#1)

Hi, I've hurriedly fixed this, so it may not be perfect - let me know.

I've issued a new release here on Github, but also on the CKEditor site.

— Reply to this email directly or view it on GitHubhttps://github.com/andykirk/CKEditorFootnotes/issues/1#issuecomment-51188117.

andykirk commented 10 years ago

It was definitely a problem with my code. The main reference to the editor object was being overridden as each instance was created. Simply a lack of understanding on my part of how CKEditor plugins instantiated themselves. I modified the code so that the correct instance is being passed around the various methods.

urs63 commented 10 years ago

Thanks – any interest in programming for ckeditor, subject footnotes? If yes contact me. Thanks

Von: andykirk [mailto:notifications@github.com] Gesendet: Dienstag, 5. August 2014 14:11 An: andykirk/CKEditorFootnotes Cc: Urs Stadelmann Betreff: Re: [CKEditorFootnotes] footnotes in wrong instance (#1)

It was definitely a problem with my code. The main reference to the editor object was being overridden as each instance was created. Simply a lack of understanding on my part of how CKEditor plugins instantiated themselves. I modified the code so that the correct instance is being passed around the various methods.

— Reply to this email directly or view it on GitHubhttps://github.com/andykirk/CKEditorFootnotes/issues/1#issuecomment-51188784.

urs63 commented 10 years ago

Could quickly test it. Very fine ! Thanks !

Von: andykirk [mailto:notifications@github.com] Gesendet: Dienstag, 5. August 2014 14:11 An: andykirk/CKEditorFootnotes Cc: Urs Stadelmann Betreff: Re: [CKEditorFootnotes] footnotes in wrong instance (#1)

It was definitely a problem with my code. The main reference to the editor object was being overridden as each instance was created. Simply a lack of understanding on my part of how CKEditor plugins instantiated themselves. I modified the code so that the correct instance is being passed around the various methods.

— Reply to this email directly or view it on GitHubhttps://github.com/andykirk/CKEditorFootnotes/issues/1#issuecomment-51188784.

andykirk commented 10 years ago

"Thanks – any interest in programming for ckeditor, subject footnotes? If yes contact me. Thanks" I don't have a private contact for you - please can you email me with more details.

Thanks.

urs63 commented 10 years ago

You can contact me under us@desmos-consult.chmailto:us@desmos-consult.ch

I do not have an email address from you.

See you Urs

De : andykirk [mailto:notifications@github.com] Envoyé : Dienstag, 5. August 2014 15:32 À : andykirk/CKEditorFootnotes Cc : Urs Stadelmann Objet : Re: [CKEditorFootnotes] footnotes in wrong instance (#1)

"Thanks – any interest in programming for ckeditor, subject footnotes? If yes contact me. Thanks" I don't have a private contact for you - please can you email me with more details.

Thanks.

— Reply to this email directly or view it on GitHubhttps://github.com/andykirk/CKEditorFootnotes/issues/1#issuecomment-51197142.

andykirk commented 10 years ago

It's on my profile :-)