search

andykirk / CKEditorFootnotes

Footnotes plugin for CKEditor
17 stars 22 forks source link

fix plugin for inline editing #11

Closed cperriard closed 9 years ago

cperriard commented 9 years ago

Hi, thank you for this great plugin. I had some problems with inline editing. Therefore I changed the jQuery statement for $contents and $footnotes to work with both iFrame and inline editing.

Please test my fix as I am new to CKEditor development. Thank you. Sorry for the confusion with the other pull request. I wanted to create another branch first.

Kind regards Cédric

andykirk commented 9 years ago

Hi, thanks for the PR. I'll take a look as soon as I can. I have this vague recollection about not supporting inline editing, but I can't remember why, now.

I'll do what I can.

Thanks

andykirk commented 9 years ago

Hi, sorry it's taken so long to get round to this. I didn't use your exact fix for this - it was mostly fixed by #15 - I just had to replicate one of the changes in the dialog file. However, it was much quicker to fix this by looking at your PR, so thanks loads for that - much appreciated.