andyleach / vue-flash

A flash messaging component for Vue.js
MIT License
45 stars 4 forks source link

Remove :key="index" #20

Closed goaround closed 5 years ago

goaround commented 5 years ago

Vue.js will emit an Error when you use index as :key "Do not use v-for index as key on children, this is the same as not using keys."

Just remove the :key="index"

ghost commented 5 years ago

I agree with @goaround, I have same issue.

Jason-C-Fry commented 5 years ago

Is this fix going to be pushed out?

goaround commented 5 years ago

@andyleach could you approve my pr and push out a new npm version?

andyleach commented 5 years ago

Thank you for notifying me of the issue, I've addressed this issue in #22.