search

andyleach / vue-flash

A flash messaging component for Vue.js
MIT License
45 stars 4 forks source link

Add bulma and fa-icon support #8

Closed olivierdrot closed 7 years ago

andyleach commented 7 years ago

Hey @olivierdrot thanks so much for taking the time that you did to make a PR to Vue-Flash. I've made some changes to your PR which can be found here. Take some time to look it over and let me know what you think.

What's included:

  1. Support for completely custom classes through a prop called types which is an object of all alert/notification classes that might be used. This removes the limit on what classes can be used so you could theoretically have an infinite number of class names assigned to different alert/notification types.
  2. Updated documentation
  3. Icon support. This functionality behaves the same way that classes using a prop called icons, with an additional prop called displayIcons to determine whether icons are turned on
olivierdrot commented 7 years ago

Hey @andyleach, this way better than the quick and dirty code I pushed :)

andyleach commented 7 years ago

Glad you like it. I will be merging it in later today.