search

andyli / jQueryExternForHaxe

Unleash the full power of jQuery in Haxe.
http://lib.haxe.org/p/jQueryExtern
65 stars 12 forks source link

Add hxnodejs require support #21

Closed malublu closed 7 years ago

andyli commented 7 years ago

Would you write a test such that I wouldn't break it by accident in the future?

malublu commented 7 years ago

I can do it, but not today. I,m currently not at home and come back at Sunday.

malublu commented 7 years ago

@andyli its more complex if we need a test for the builded nodejs scripts. Do we need one? I think, if we need one, we should test it with something like electron.

andyli commented 7 years ago

So, you're using electron? I thought you are using jQuery in pure nodejs.

I believe we can do something like https://www.npmjs.com/package/jquery#node

malublu commented 7 years ago

Yes i using electron. The jsdom package could be the solution for testing. Currently i have no idea how travis and nodejs testing works.

andyli commented 7 years ago

No problem, I can add the test myself.

Would you fix the spaces and indentation as shown in the diff view? I will merge the PR when it is done.