search

andylokandy / simsearch-rs

A simple and lightweight fuzzy search engine that works in memory, searching for similar strings (a pun here).
MIT License
167 stars 25 forks source link

Use criterion for benches #1

Closed mexus closed 5 years ago

mexus commented 5 years ago

Hi Andy and thanks for you crate!

I wanted to implement a fuzzy search in rust for some time, and thanks to your post on reddit I've discovered that the work is already done ;)

I looked at your benches and found out that you're not using criterion, which can draw fancy plots for you and provide a comparison with a previous run (very helpful when you're trying to improve the performance), so here's a PR that migrates the benches. The only other thing apart from just migrating I've also made the add 100 bench to insert items into an empty engine on each benchmark iteration, which I believe made the bench to be more fair.

andylokandy commented 5 years ago

Thank you so much! This seems also help running benchmark on stable channel!

mexus commented 5 years ago

Wow that was fast! I haven't even realized that the PR is already merged %)