Get rid of php.js dependency.

andymantell / node-wpautop

A Node.js port of Wordpress' wpautop() function

GNU General Public License v2.0

16 stars 7 forks source link

Get rid of php.js dependency. #2

Closed mttmzr closed 8 years ago

mttmzr commented 8 years ago

If you are interested in getting rid of the phpjs dependency...

phpjs is still needed for the tests.

andymantell commented 8 years ago

Thanks @matt-mx - could you look into why the tests are failing?

mttmzr commented 8 years ago

Damn ES6 (or whatever it is called currently) ;-)

mttmzr commented 8 years ago

Oh, just discovered that the Travis CI build is run against NodeJS v0.11.x. I'm running v6.3 locally and all tests are passing. I guess I'm using some funcionality from newer Node versions.

Have you considered updating the Node version in .travis.yml or do you rather keep it as is?

mttmzr commented 8 years ago

Finally...

andymantell commented 8 years ago

Oh good point, I haven't touched this thing in ages. Best bet would be to update travis so that it runs the tests across multiple versions of node I reckon