In https://github.com/andymatuschak/orbit/pull/198 I made the mistake of not explicitly setting the path for ESLint. I foolishly assumed that forgoing the path would mean ESLint would lint all the directories, but instead it lints nothing. It finishing in 0.5s should have been a clear giveaway 🤦♂️.
Anyways, I went ahead and reversed my change where I removed the path from the command. I also changed the postinstall script to call eslint directly instead of using yarn lint to ensure that we are only running lint fix on that single file.
andymatuschak
commented
3 years ago
Sorry for the flurry of PR's today...
In https://github.com/andymatuschak/orbit/pull/198 I made the mistake of not explicitly setting the path for ESLint. I foolishly assumed that forgoing the path would mean ESLint would lint all the directories, but instead it lints nothing. It finishing in 0.5s should have been a clear giveaway 🤦♂️.
Anyways, I went ahead and reversed my change where I removed the path from the command. I also changed the
postinstallscript to call eslint directly instead of usingyarn lintto ensure that we are only running lint fix on that single file.